Player Hidden Keywords related to SearchLibrary#10219
Player Hidden Keywords related to SearchLibrary#10219kojotak wants to merge 4 commits intoCard-Forge:masterfrom
Conversation
forge-game/src/main/java/forge/game/staticability/StaticAbilitySearchLibrary.java
Show resolved
Hide resolved
| Types:Creature Cat Cleric | ||
| PT:2/2 | ||
| S:Mode$ Continuous | Affected$ Player | AddKeyword$ CantSearchLibrary | IgnoreEffectCost$ 2 | Description$ Players can't search libraries. Any player may pay {2} for that player to ignore this effect until end of turn. | ||
| S:Mode$ CantSearchLibrary | ValidPlayer$ Player | IgnoreEffectCost$ 2 | Description$ Players can't search libraries. Any player may pay {2} for that player to ignore this effect until end of turn. |
There was a problem hiding this comment.
@kojotak check "Volrath's Curse" for both Continuous and other modes
in this case, it should be something like this:
Mode$ Continuous,CantSearchLibrary | Affected$ Player | ValidPlayer$ Player | IgnoreEffectCost$ 2
There was a problem hiding this comment.
Thanks, good hint. It was also neccessary to check getIgnoreEffectPlayers in cantSearchLibrary so it finally works.
Tested:
- payed 2R for ignore effect
- 2W for Stoneforge mystic - confirm trigger
- select an equipment from library
kojotak
force-pushed
the
issue/4760/searchLibrary
branch
from
496b3a5 to
98f3002
Compare
| } | ||
| return targetPlayer == null || !targetPlayer.equals(sa.getActivatingPlayer()) | ||
| || !hasKeyword("Spells and abilities you control can't cause you to search your library."); | ||
| || !StaticAbilityCantSearchLibrary.cantCauseToSearchLibrary(this); |
There was a problem hiding this comment.
this should just use the same method above so it can be more dynamic
There was a problem hiding this comment.
Do you mean:
- remove the
cantCauseToSearchLibrary()method completely - add check for
CantCauseToSearchLibrarymode intocantSearchLibrary()?
There was a problem hiding this comment.
it's just a slightly more specific variant, not a different mode
we usually have one entry point, so scripts can just use params for their needs
| K:Flash | ||
| K:Flying | ||
| S:Mode$ Continuous | Affected$ Player.Opponent | AddKeyword$ LimitSearchLibrary | Description$ If an opponent would search a library, that player searches the top four cards of that library instead. | ||
| S:Mode$ LimitSearchLibrary | ValidPlayer$ Player.Opponent | LimitNum$ 4 | Description$ If an opponent would search a library, that player searches the top four cards of that library instead. |
There was a problem hiding this comment.
technically this is a replacement effect
not sure yet if the static approach is better for both
3 participants
An attempt to refactor 3 hidden player keywords related to "search library" from #4760 :
Tested using
Stoneforge Mystic,Mindlock Orb,Ashiok, Dream Render,Aven Mindcensor. Example of applying library search limit of 4 cards: